fix(kv): use multipart/form-data for values.update() requests#2683
Open
christhorwarth wants to merge 1 commit intocloudflare:nextfrom
Open
fix(kv): use multipart/form-data for values.update() requests#2683christhorwarth wants to merge 1 commit intocloudflare:nextfrom
christhorwarth wants to merge 1 commit intocloudflare:nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Fixes #2519 - When setting a KV value with metadata, the request was being
sent as JSON which caused the entire body to be stored as the value. Now
correctly sends as multipart/form-data so value and metadata are separate
form fields.
Additional context & links
#2519